Skip to content

Add deprecationMessage for deprecated DownloadPackageV0 and NuGet... tasks #19457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rumyax
Copy link
Contributor

@rumyax rumyax commented Jan 23, 2024

Tasks:
DownloadPackage@0
NuGetInstaller@0
NuGetPackager@0
NuGetPublisher@0
NuGetRestore@1
NuGet@0

NuGetAuthenticate@0 is not included

Description: Add the tailored deprecation message in addition to the common deprecation message.

Documentation changes required: No

Added unit tests: No

Attached related issue: N/A

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@rumyax rumyax marked this pull request as ready for review January 23, 2024 11:51
@rumyax rumyax requested a review from a team as a code owner January 23, 2024 11:51
Copy link
Contributor

@amp-powell amp-powell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but possibly we can add links when suggesting the new tasks to use. Also, it's fine to add the depreciationMessage property to DownloadPackageV0, NuGetInstallerV0, and NuGetRestoreV1, but these tasks are already failing.

@rumyax
Copy link
Contributor Author

rumyax commented Feb 27, 2024

@amp-powell This PR has been created in addition to another one. The link to the documentation is not provided in the tailored deprecation message since it is already included in the common deprecation message.

…ge-for-deprecated-download-package-and-nuget-tasks
@DmitriiBobreshev
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

rumyax added 5 commits March 5, 2024 11:06
…ated-download-package-and-nuget-tasks' of https://github.com/microsoft/azure-pipelines-tasks into users/DenisRumyantsev/add-deprecationMessage-for-deprecated-download-package-and-nuget-tasks
…ge-for-deprecated-download-package-and-nuget-tasks
…ated-download-package-and-nuget-tasks' of https://github.com/microsoft/azure-pipelines-tasks into users/DenisRumyantsev/add-deprecationMessage-for-deprecated-download-package-and-nuget-tasks
@rumyax rumyax requested a review from geekzter March 5, 2024 10:30
…ge-for-deprecated-download-package-and-nuget-tasks
@rumyax rumyax merged commit 23cdb45 into master Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants